Migrate typecheck to TypeScript 7 RC#48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript-7alias fortypescript@7.0.1-rc.typescript@^6.0.3fortypescript-eslint's current JS API and peer range.npm run typecheckthroughnode ./node_modules/typescript-7/bin/tscso project typechecking uses the TS 7 RC compiler.Detail
typescript-eslint@8.62.xstill peers ontypescript >=4.8.4 <6.1.0and imports the stabletypescriptJS API. Installingtypescript@7.0.1-rcas the primarytypescriptpackage breaks lint because the TS 7 RC package exposestscbut does not expose that stable CommonJS API.This uses the side-by-side layout instead: TS 6 remains the package consumed by lint tooling, while the project typecheck script invokes the TS 7 compiler alias directly.
Test plan
node ./node_modules/typescript-7/bin/tsc --version npm run typecheck --silent npm run lint --silent npm run test --silent npm run build --silent npm run prettier:check --silentPrecommit also ran
npm run lint,npm run prettier:write, andnpm run test.