Skip to content

Pin implicit SDK pack versions - #72

Merged
Kamilr616 merged 1 commit into
mainfrom
agent/pin-sdk-pack-locks
Jul 15, 2026
Merged

Pin implicit SDK pack versions#72
Kamilr616 merged 1 commit into
mainfrom
agent/pin-sdk-pack-locks

Conversation

@Kamilr616

Copy link
Copy Markdown
Owner

What changed

  • removes explicit references to SDK-owned ILLink and WebAssembly pack packages,
  • pins their versions through a target that runs immediately before ProcessFrameworkReferences,
  • preserves the existing cross-platform lock file versions required by the pinned .NET SDK.

Why

The explicit Microsoft.NET.ILLink.Tasks reference made locked restore deterministic across Windows and Linux, but the SDK warns that explicit references to this package can cause versioning problems during publish. Updating the SDK-owned pack metadata retains deterministic restore without treating SDK implementation packages as application dependencies.

Validation

  • locked restore passed,
  • formatting verification passed,
  • Release build passed with warnings treated as errors,
  • 34/34 tests passed,
  • Release publish passed with warnings treated as errors,
  • the previous explicit ILLink package warning is no longer emitted.

@Kamilr616
Kamilr616 marked this pull request as ready for review July 15, 2026 00:23
Copilot AI review requested due to automatic review settings July 15, 2026 00:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Blazor WASM client project to keep restore deterministic under locked mode while avoiding explicit references to SDK-implementation packages (which can cause publish-time SDK warnings and versioning issues).

Changes:

  • Removed explicit PackageReference entries for Microsoft.NET.ILLink.Tasks and Microsoft.NET.Sdk.WebAssembly.Pack.
  • Added an MSBuild target that pins the SDK-owned pack versions via KnownILLinkPack / KnownWebAssemblySdkPack updates before ProcessFrameworkReferences.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Kamilr616
Kamilr616 merged commit f493dbc into main Jul 15, 2026
2 checks passed
@Kamilr616
Kamilr616 deleted the agent/pin-sdk-pack-locks branch July 15, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants