Pin implicit SDK pack versions - #72
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Blazor WASM client project to keep restore deterministic under locked mode while avoiding explicit references to SDK-implementation packages (which can cause publish-time SDK warnings and versioning issues).
Changes:
- Removed explicit
PackageReferenceentries forMicrosoft.NET.ILLink.TasksandMicrosoft.NET.Sdk.WebAssembly.Pack. - Added an MSBuild target that pins the SDK-owned pack versions via
KnownILLinkPack/KnownWebAssemblySdkPackupdates beforeProcessFrameworkReferences.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The explicit Microsoft.NET.ILLink.Tasks reference made locked restore deterministic across Windows and Linux, but the SDK warns that explicit references to this package can cause versioning problems during publish. Updating the SDK-owned pack metadata retains deterministic restore without treating SDK implementation packages as application dependencies.
Validation