Cdfs redir fixes#40
Open
QuzarDC wants to merge 2 commits into
Open
Conversation
added 2 commits
July 11, 2026 14:29
gdGdcReqCmd was returning 0 for success and -1 for failure. This kind of worked with old KOS and a patch had been kept in for it to continue to somewhat work, but it was just wrong. The actual BIOS returns a 0 on failure (indicating 'retry') and a non-zero request ID on success. Implement a simple form of this where we just return an arbitrary incremented ID value for each request. We don't track this ID for replying to status or aborting commands like the BIOS does though.
It is treated identically to the standard PIO transfer. This should fix cdfs support which has been broken since KOS switched to DMA as the default transfer method in KallistiOS/KallistiOS#659
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDFS redirection hasn't worked right since a lot of the updates to the core KOS driver in early 2024, and was entirely broken since the switch to DMA transfers as default in KallistiOS/KallistiOS#659
This generally matches the fixes as implemented here: andressbarajas/kos-tool@71856a1 and following the discord discussion here: https://discord.com/channels/488332893324836864/488332893324836866/1523760146772398321