fix: adapt quest tracker height to content - #292
Open
postyizhan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the quest tracker background panel leaving unnecessary empty shadow space below its content.
The tracker height is now calculated dynamically from the content currently being displayed, including:
This keeps the semi-transparent background aligned with the actual content instead of always using the fixed default height.
Before
The quest tracker used a fixed height, leaving a large empty shadow area below shorter quest content.
After
The background panel now adapts to the rendered content height.
Implementation
Added an
updateOverlayHeight()calculation toQuestTrackingComponent. The calculated height follows the same line-height and spacing rules used by the rendering flow.Testing
IAbilityEvent.DefendEventis available from thedevAPI submodule revision./gradlew compileJavaBuild Result