Add programmer skill: senior-engineer judgment from 8 SWE books#184
Open
Chenwei-1999 wants to merge 2 commits into
Open
Add programmer skill: senior-engineer judgment from 8 SWE books#184Chenwei-1999 wants to merge 2 commits into
Chenwei-1999 wants to merge 2 commits into
Conversation
A portable, agent-neutral skill giving a coding agent senior-engineer judgment across naming, functions, comments, error handling, complexity, module/OO design, SOLID, architecture boundaries, data systems, concurrency, testing, code review, and idiomatic Python. Each rule is tagged with the book(s) behind it. Two-tier design: Tier 1 is embedded distilled judgment (SKILL.md plus per-book reference catalogs); Tier 2 fetches the primary source on demand for high-stakes or contested calls. No book PDFs are shipped -- the catalogs are original distillations and the source texts remain with their owners. Conforms to the Agent Skills frontmatter spec: name matches the directory and metadata.version is "1.0".
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b10397731e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Address Codex review on PR K-Dense-AI#184. The router-level Tier-2 instruction told the agent to fetch a book PDF without the authorization constraint that assets/README.md and the Additional Resources section already carry, so on a network-enabled runner the agent could auto-download copyrighted books -- undermining the skill's stated no-copyrighted-PDFs design. Align the primary instruction to require a copy the reader is entitled to from a legitimate source, matching the other two fetch mentions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a new skill at
skills/programmer/— a portable, agent-neutral skill that gives a coding agent senior-engineer judgment across naming, functions, comments, error handling, complexity management, module/OO design, SOLID, architecture boundaries, data systems, concurrency, testing, code review, long-term engineering trade-offs, and idiomatic Python.Why it fits this repo
Scientific software is read and changed far more than it is written — reproducible pipelines, data-intensive workflows, and shared lab codebases live for years. This skill is the cross-cutting code-quality layer for that work: it helps an agent write and review the engineering around scientific packages (e.g. structuring an
anndata/scanpypipeline, designing storage/replication trade-offs à la DDIA), complementing the domain skills already here.Design
SKILL.md+ per-book catalogs inreferences/). Tier 2 is a deliberate path to primary sources for high-stakes or contested calls.references/catalogs are original distillations; source texts stay with their owners. A nested.gitignorekeeps any on-demand-fetched book PDF out of the repo.Format / spec conformance
name: programmermatches the directory name.metadata.version: "1.0"present and quoted (new skill).SKILL.mdis 324 lines (under the 500-line recommendation); long material lives one level deep inreferences/.Layout
Testing
Frontmatter conforms to the required Agent Skills format and this repo's
metadata.versionconvention.scripts/read_book.pyis a self-contained CLI (--list/--query) over an extractor withpdftotext/pypdf/PyPDF2/built-in fallbacks. Theskills-ref/skill-scannervalidators were not run in the authoring environment; happy to address any validator findings in review.