Extend IGMP slice implementation - #160
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughIGMP support is extended across typed zero-copy message slices, transport parsing, packet building, payload representations, composition tests, examples, and documentation. IGMPv1/v2/v3 messages now have typed accessors, iterator support, checksum handling, and IPv4/IPv6 transport integration. ChangesIGMP protocol integration
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@etherparse/src/transport/igmp/membership_query_with_sources_slice.rs`:
- Around line 35-38: Update the # Safety documentation for from_slice_unchecked
to require that slice contains the complete declared payload: at least 12 +
num_of_sources * 4 bytes, where num_of_sources is read from the header. Retain
the existing minimum header-length requirement while explicitly covering all
source addresses used by source_addrs_bytes().
In `@etherparse/src/transport/igmp/membership_report_v2_slice.rs`:
- Line 9: Correct the ASCII diagram’s Type field in the IGMPv2 membership report
documentation to 0x16, matching the struct’s documented message type and the
IgmpSlice::from_slice dispatch constant.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 281c47a7-06e9-4b77-b005-a14e393985f6
📒 Files selected for processing (33)
README.mdchangelog.mdetherparse/examples/read_by_slicing.rsetherparse/proptest-regressions/compositions_tests.txtetherparse/src/compositions_tests.rsetherparse/src/lax_packet_headers.rsetherparse/src/lax_payload_slice.rsetherparse/src/lax_sliced_packet.rsetherparse/src/lax_sliced_packet_cursor.rsetherparse/src/lib.rsetherparse/src/net/ipv6_fragment_header.rsetherparse/src/packet_builder.rsetherparse/src/packet_headers.rsetherparse/src/payload_slice.rsetherparse/src/sliced_packet.rsetherparse/src/sliced_packet_cursor.rsetherparse/src/test_gens/mod.rsetherparse/src/test_packet.rsetherparse/src/transport/igmp/igmp_unknown_slice.rsetherparse/src/transport/igmp/leave_group_slice.rsetherparse/src/transport/igmp/membership_query_slice.rsetherparse/src/transport/igmp/membership_query_with_sources_slice.rsetherparse/src/transport/igmp/membership_report_v1_slice.rsetherparse/src/transport/igmp/membership_report_v2_slice.rsetherparse/src/transport/igmp/membership_report_v3_slice.rsetherparse/src/transport/igmp/mod.rsetherparse/src/transport/igmp/report_group_record_v3_slice.rsetherparse/src/transport/igmp_header.rsetherparse/src/transport/igmp_slice.rsetherparse/src/transport/transport_header.rsetherparse/src/transport/transport_slice.rsetherparse/tests/transport/icmpv4.rsetherparse/tests/transport/icmpv6.rs
Summary by CodeRabbit
New Features
Documentation
Tests