Harden flaky transport CI tests#1323
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1323 +/- ##
=======================================
Coverage 87.96% 87.96%
=======================================
Files 30 30
Lines 11807 11807
=======================================
Hits 10386 10386
Misses 1421 1421 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
71eb27e to
b98d88e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hardens two timing-sensitive transport tests that failed on a recent release-adjacent master CI run even though the immediately following master run passed.
roundtrip!returns while the upload callback is blocked.Why
The failed CI run showed two test-fragility signals rather than a product regression:
elapsed < 0.75by about 13 ms.Validation
julia --startup-file=no --project=. test/http_client_transport_tests.jljulia --startup-file=no --project=. test/http_server_http1_tests.jlgit diff --checkCo-authored by Codex