Skip to content

Fix breakage caused by JuliaLang/LinearAlgebra.jl#1668 - #747

Open
yuyichao wants to merge 1 commit into
JuliaSparse:mainfrom
yuyichao:fixcase
Open

Fix breakage caused by JuliaLang/LinearAlgebra.jl#1668#747
yuyichao wants to merge 1 commit into
JuliaSparse:mainfrom
yuyichao:fixcase

Conversation

@yuyichao

Copy link
Copy Markdown
Contributor

I don't think the new name for this function is the right decision but at least this should fix the breakage.

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.39%. Comparing base (ce9fe78) to head (60ff2bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #747   +/-   ##
=======================================
  Coverage   84.39%   84.39%           
=======================================
  Files          13       13           
  Lines        9382     9383    +1     
=======================================
+ Hits         7918     7919    +1     
  Misses       1464     1464           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@araujoms

Copy link
Copy Markdown
Contributor

JuliaLang/LinearAlgebra.jl#1679 fixed it, but your PR is a better solution because we then get the advantages of _uppercase.

I have to apologise, I didn't realise that this was a public interface used by other packages.

Which name would you prefer, though? There is still time to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants