adding a shifted version of NormLinf, without and with bounds - #162
adding a shifted version of NormLinf, without and with bounds#162BenjaminPINEAU wants to merge 3 commits into
Conversation
|
Currently working on allocation test but i do not have idea to implement the function If you have any ideas, I'd love to hear them @dpo @MaxenceGollier |
|
rebase |
|
@BenjaminPINEAU I recommend to use the following workflow when you work on multiple branches. Don't worry though, this branch error still happens to me, to fix now what you can do is synchronize your fork and then do I'd say the best practice is to always check the git diff when you open PRs to make sure that you are trying to merge the correct commits. |
I am not sure to understand what is preventing you from an inplace implementation. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 73.71% 74.31% +0.59%
==========================================
Files 22 27 +5
Lines 898 1094 +196
==========================================
+ Hits 662 813 +151
- Misses 236 281 +45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Implementation of
shiftedNormLinf.jl, a version of shiftedGroupL2Normwithout bounds, andshiftedNormLinfBox.jl, a version ofGroupL2Normwith bounds.