Format prox! functions according to ProximalOperators package - #161
Draft
BenjaminPINEAU wants to merge 4 commits into
Draft
Format prox! functions according to ProximalOperators package#161BenjaminPINEAU wants to merge 4 commits into
BenjaminPINEAU wants to merge 4 commits into
Conversation
BenjaminPINEAU
marked this pull request as draft
July 3, 2026 15:32
Collaborator
|
rebase |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 73.71% 78.71% +4.99%
==========================================
Files 22 25 +3
Lines 898 1076 +178
==========================================
+ Hits 662 847 +185
+ Misses 236 229 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix prox! return value: return$h(prox(x))$ instead of the prox vector
All prox! functions now return the scalar value$h(y)$ where $y = prox_{σh}(x)$ , instead of returning y itself. This is necessary for correct computation of the Moreau envelope $h_μ(z) = h(prox_{μh}(z)) + 1/(2μ)‖z - prox_{μh}(z)‖²$ .
The prox() wrapper (which returns the prox vector) is unchanged.
Fixes #160