Skip to content

Update breakage: use organization-wide workflow - #147

Merged
tmigot merged 2 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage
Jul 31, 2026
Merged

Update breakage: use organization-wide workflow#147
tmigot merged 2 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage

Conversation

@MaxenceGollier

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings July 27, 2026 15:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

.github/workflows/Breakage.yml:9

  • The reusable workflow reference is pinned to the mutable @main branch. Pinning to a tag or commit SHA reduces supply-chain risk and makes runs reproducible. Also consider setting explicit minimal permissions for the called workflow (at least contents: read for checkout) so behavior doesn’t depend on repository default token permissions.
jobs:
  breakage:
    uses: JuliaSmoothOptimizers/.github/.github/workflows/Breakage.yml@main

.github/workflows/CommentBreakage.yml:11

  • This workflow currently runs on every completed Breakage run, even when Breakage fails; the called reusable workflow then skips internally, but the extra workflow run is still created. Adding a job-level if avoids the unnecessary run. Also, the called workflow downloads artifacts and comments on PRs, which requires explicit token permissions (actions: read, pull-requests: write) in repositories that default GITHUB_TOKEN to read-only. Finally, pin the reusable workflow ref instead of @main to avoid a mutable dependency.
jobs:
  comment_pr:
    uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@main

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (90eb234) to head (4d36d73).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   98.87%   97.66%   -1.21%     
==========================================
  Files          27       27              
  Lines        3657     3775     +118     
==========================================
+ Hits         3616     3687      +71     
- Misses         41       88      +47     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/workflows/Breakage.yml Outdated
Comment thread .github/workflows/CommentBreakage.yml Outdated
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>

@tmigot tmigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmigot
tmigot merged commit e9e1d2d into JuliaSmoothOptimizers:main Jul 31, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants