Update breakage: use organization-wide workflow - #147
Merged
tmigot merged 2 commits intoJul 31, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
.github/workflows/Breakage.yml:9
- The reusable workflow reference is pinned to the mutable
@mainbranch. Pinning to a tag or commit SHA reduces supply-chain risk and makes runs reproducible. Also consider setting explicit minimalpermissionsfor the called workflow (at leastcontents: readfor checkout) so behavior doesn’t depend on repository default token permissions.
jobs:
breakage:
uses: JuliaSmoothOptimizers/.github/.github/workflows/Breakage.yml@main
.github/workflows/CommentBreakage.yml:11
- This workflow currently runs on every completed Breakage run, even when Breakage fails; the called reusable workflow then skips internally, but the extra workflow run is still created. Adding a job-level
ifavoids the unnecessary run. Also, the called workflow downloads artifacts and comments on PRs, which requires explicit token permissions (actions: read,pull-requests: write) in repositories that default GITHUB_TOKEN to read-only. Finally, pin the reusable workflow ref instead of@mainto avoid a mutable dependency.
jobs:
comment_pr:
uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@main
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 98.87% 97.66% -1.21%
==========================================
Files 27 27
Lines 3657 3775 +118
==========================================
+ Hits 3616 3687 +71
- Misses 41 88 +47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tmigot
reviewed
Jul 31, 2026
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following JuliaSmoothOptimizers/.github#18.