Update breakage: use organization-wide workflow - #565
Merged
tmigot merged 2 commits intoJul 31, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (3)
.github/workflows/Breakage.yml:9
- The reusable workflow reference is pinned to the moving
mainbranch. This makes the breakage checks non-reproducible and creates a supply-chain risk (the workflow behavior can change without any change in this repo). Pin to a specific commit SHA (and bump it deliberately when you want updates).
uses: JuliaSmoothOptimizers/.github/.github/workflows/Breakage.yml@main
.github/workflows/CommentBreakage.yml:11
- The reusable workflow reference is pinned to the moving
mainbranch. Pinning to a commit SHA makes the PR-commenting behavior deterministic and avoids unexpected changes coming from the shared workflow repo.
uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@main
.github/workflows/CommentBreakage.yml:11
- The shared
CommentBreakagereusable workflow downloadsbreakage-*artifacts; the underlyingdawidd6/action-download-artifactdefaults to failing when no artifacts are found. The sharedBreakageworkflow can exit early with no dependents (matrix empty), which means nobreakage-*artifacts exist and this workflow_run will likely fail even though breakage was a no-op.
This needs a change in the org workflow (e.g., set if_no_artifact_found: warn|ignore for the breakage artifact download, or always upload a placeholder artifact when the matrix is empty) and then pin to that fixed commit.
workflow_run:
workflows: ["Breakage"]
types:
- completed
jobs:
comment_pr:
uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@main
tmigot
reviewed
Jul 31, 2026
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following JuliaSmoothOptimizers/.github#18.