Skip to content

Update breakage: use organization-wide workflow - #565

Merged
tmigot merged 2 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage
Jul 31, 2026
Merged

Update breakage: use organization-wide workflow#565
tmigot merged 2 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage

Conversation

@MaxenceGollier

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings July 22, 2026 15:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Suppressed comments (3)

.github/workflows/Breakage.yml:9

  • The reusable workflow reference is pinned to the moving main branch. This makes the breakage checks non-reproducible and creates a supply-chain risk (the workflow behavior can change without any change in this repo). Pin to a specific commit SHA (and bump it deliberately when you want updates).
    uses: JuliaSmoothOptimizers/.github/.github/workflows/Breakage.yml@main

.github/workflows/CommentBreakage.yml:11

  • The reusable workflow reference is pinned to the moving main branch. Pinning to a commit SHA makes the PR-commenting behavior deterministic and avoids unexpected changes coming from the shared workflow repo.
    uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@main

.github/workflows/CommentBreakage.yml:11

  • The shared CommentBreakage reusable workflow downloads breakage-* artifacts; the underlying dawidd6/action-download-artifact defaults to failing when no artifacts are found. The shared Breakage workflow can exit early with no dependents (matrix empty), which means no breakage-* artifacts exist and this workflow_run will likely fail even though breakage was a no-op.

This needs a change in the org workflow (e.g., set if_no_artifact_found: warn|ignore for the breakage artifact download, or always upload a placeholder artifact when the matrix is empty) and then pin to that fixed commit.

  workflow_run:
    workflows: ["Breakage"]
    types:
      - completed

jobs:
  comment_pr:
    uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@main

Comment thread .github/workflows/Breakage.yml Outdated
Comment thread .github/workflows/CommentBreakage.yml Outdated
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>

@tmigot tmigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmigot
tmigot merged commit 915381e into JuliaSmoothOptimizers:main Jul 31, 2026
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants