Skip to content

Extract hardcoded strings and update Arabic translation #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshAtticus merged 3 commits into from
Jul 3, 2026
Merged

Extract hardcoded strings and update Arabic translation #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee4609c
Update MainActivity.kt
AhmedRX20 Jul 2, 2026
087226c
Update strings.xml
AhmedRX20 Jul 3, 2026
a9966a4
Update strings.xml
AhmedRX20 Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions app/src/main/java/compress/joshattic/us/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ fun CompressorApp(viewModel: CompressorViewModel) {
),
actions = {
IconButton(onClick = { showInfoDialog = true }) {
Icon(Icons.Outlined.Info, contentDescription = "Info", tint = MaterialTheme.colorScheme.onSurface)
Icon(Icons.Outlined.Info, contentDescription = stringResource(R.string.info_content_desc), tint = MaterialTheme.colorScheme.onSurface)
}
}
)
Expand Down Expand Up @@ -679,8 +679,8 @@ fun InfoDialog(
},
text = {
Column(modifier = Modifier.verticalScroll(rememberScrollState())) {
InfoRow("Device", "${android.os.Build.MANUFACTURER} ${android.os.Build.MODEL}")
InfoRow("Android", android.os.Build.VERSION.RELEASE)
InfoRow(stringResource(R.string.info_device), "${android.os.Build.MANUFACTURER} ${android.os.Build.MODEL}")
InfoRow(stringResource(R.string.info_android), android.os.Build.VERSION.RELEASE)

Spacer(modifier = Modifier.height(16.dp))
HorizontalDivider()
Expand Down Expand Up @@ -720,7 +720,7 @@ fun InfoDialog(
HorizontalDivider()
Spacer(modifier = Modifier.height(8.dp))

InfoRow("Supported Codecs", "")
InfoRow(stringResource(R.string.info_supported_codecs), "")
state.supportedCodecs.forEach { codec ->
Text(
"• ${codec.substringAfter("/")}",
Expand Down Expand Up @@ -782,7 +782,7 @@ fun ConfigScreen(
) {
val pagerState = rememberPagerState(pageCount = { 3 })
val scope = rememberCoroutineScope()
val tabs = listOf("Presets", "Video", "Audio")
val tabs = listOf(stringResource(R.string.tab_presets), stringResource(R.string.tab_video), stringResource(R.string.tab_audio))
val haptics = LocalHapticFeedback.current

val originalMb = state.originalSize / (1024f * 1024f)
Expand All @@ -806,21 +806,21 @@ fun ConfigScreen(
selected = pagerState.currentPage == 0,
onClick = { scope.launch { pagerState.animateScrollToPage(0) } },
icon = { Icon(Icons.Default.Settings, contentDescription = null) },
label = { Text("Presets") }
label = { Text(stringResource(R.string.tab_presets)) }
)
Spacer(Modifier.height(12.dp))
NavigationRailItem(
selected = pagerState.currentPage == 1,
onClick = { scope.launch { pagerState.animateScrollToPage(1) } },
icon = { Icon(Icons.Default.PlayArrow, contentDescription = null) },
label = { Text("Video") }
label = { Text(stringResource(R.string.tab_video)) }
)
Spacer(Modifier.height(12.dp))
NavigationRailItem(
selected = pagerState.currentPage == 2,
onClick = { scope.launch { pagerState.animateScrollToPage(2) } },
icon = { Icon(Icons.Default.Star, contentDescription = null) },
label = { Text("Audio") }
label = { Text(stringResource(R.string.tab_audio)) }
)
Spacer(Modifier.weight(1f))
}
Expand Down
8 changes: 8 additions & 0 deletions app/src/main/res/values-ar/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,12 @@
<string name="copy_logs">نسخ السجلات</string>
<string name="open_issue_tracker">فتح متتبع المشكلات</string>
<string name="view_on_github">عرض على GitHub</string>

<string name="info_content_desc">معلومات</string>
<string name="tab_presets">الإعدادات المسبقة</string>
<string name="tab_video">الفيديو</string>
<string name="tab_audio">الصوت</string>
<string name="info_device">الجهاز</string>
<string name="info_android">أندرويد</string>
<string name="info_supported_codecs">التراميز المدعومة</string>
</resources>
9 changes: 9 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,13 @@
<string name="copy_logs">Copy Logs</string>
<string name="open_issue_tracker">Open Issue Tracker</string>
<string name="view_on_github">View on GitHub</string>

<!-- Previously hardcoded strings -->
<string name="info_content_desc">Info</string>
<string name="tab_presets">Presets</string>
<string name="tab_video">Video</string>
<string name="tab_audio">Audio</string>
<string name="info_device">Device</string>
<string name="info_android">Android</string>
<string name="info_supported_codecs">Supported Codecs</string>
</resources>
Loading