Skip to content

Fix: Add ALL_MODULES_STARTED fallback for missed DOM_OBJECTS_CREATED #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DGessinger wants to merge 1 commit into from
Closed

Fix: Add ALL_MODULES_STARTED fallback for missed DOM_OBJECTS_CREATED #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions MMM-Remote-Control.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@ Module.register("MMM-Remote-Control", {
Log.debug(`${this.name} received a module notification: ${notification} from sender: ${sender}`);
switch (notification) {
case "DOM_OBJECTS_CREATED":
// Fallback: DOM_OBJECTS_CREATED can occasionally fire before this module
+ // has fully registered as a notification listener (race condition seen with
+ // newer Node.js/Electron versions), causing the event to be missed and the
+ // module to stay permanently "not initialized". ALL_MODULES_STARTED is
+ // received reliably afterwards and acts as a safety net.
+ case "ALL_MODULES_STARTED":
+ if (this.currentDataSent) { break; }
+ this.currentDataSent = true;
this.sendSocketNotification("REQUEST_DEFAULT_SETTINGS");
this.sendCurrentData();
break;
Expand Down
Loading