Skip to content

Install ioda on Ubuntu#2067

Closed
AlexanderHrabski-NOAA wants to merge 1 commit into
JCSDA:developfrom
AlexanderHrabski-NOAA:ioda-ubuntu-fix
Closed

Install ioda on Ubuntu#2067
AlexanderHrabski-NOAA wants to merge 1 commit into
JCSDA:developfrom
AlexanderHrabski-NOAA:ioda-ubuntu-fix

Conversation

@AlexanderHrabski-NOAA

Copy link
Copy Markdown
Collaborator

Description

Currently, the package ioda won't install on Ubuntu due to a missing path in the @run_after(install) block. fix_ioda_yaml_root_path() attempts to use a hardcoded path lib64\cmake\... which breaks on Ubuntu, where lib rather than lib64 is used. This PR adds a statement to handle both cases, allowing for ioda to be installed either way.

Dependencies

None.

Issues addressed

None.

Applications affected

Any application that attempts to build ioda on Ubuntu (or other Debian-based OS's). lib64 is the default and is always used if it exists, so no change of behavior is expected anywhere ioda already installs.

Systems affected

No supported systems should be affected.

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not

    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added: List and describe any new tests added to GitHub actions

  • Additional testing: Add information on any additional tests conducted

    • Built ioda successfully on Ubuntu WSL
    • Built ioda successfully on Ursa (to verify lib64 is used when appropriate)

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged

@climbfuji climbfuji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at #2063 - this should fix your error?

@AlexanderHrabski-NOAA

Copy link
Copy Markdown
Collaborator Author

Yes that should do it! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants