feat: db push transport + progress polish (large-DB feedback #13–#15)#5
Merged
Conversation
…-#15) From a 166 MB full-parity push (round 3): - #13 scp uploads with -C (compress in transit); SQL compresses ~5-10x - #14 non-TTY runs (pipe/CI/background) emit one-line phase markers to stderr instead of going silent for the whole push (ora spinners are TTY-only) - #15 db push summary reports elapsed time + throughput (e.g. "144s (1.2 MB/s)") #16 (search-replace table scoping, --verify readiness check, backup retention) deferred — larger/new surface. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Finalize CHANGELOG header + bump for db push transport/progress polish (scp -C compression, non-TTY phase markers, elapsed/throughput in summary). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-3 feedback from a 166 MB full-parity
db push(completed correctly in 144s). The transform logic (prefix rewrite, role/cap remap, guid-skip, backup-first, failure-path output) held up at 250× the original test size — it's the transport + progress that needed polish. All findings were verified againstcommands/db.ts+lib/ssh-connection.ts.Changes
-C(lib/ssh-connection.ts→scpArgs). The dump was transferred uncompressed; SQL compresses ~5–10×, so this cuts a large share of upload time on big dumps. Applies to every scp upload (db push, plugin zip).oraspinners are suppressed when stdout isn't a TTY, so piped/CI/background pushes printed nothing for 144s (looked hung).spinner()now returns a stub that emits one-line phase markers to stderr (Backing up… / Uploading… / Importing… / Rewriting URLs…). Kept silent in--json/INSTAWP_QUIET; stdout + the final summary stay clean for capture.db pushnow reportselapsed: 144s (1.2 MB/s).Deferred — #16 (misc, larger surface)
Left for a follow-up; noted so it's not lost:
--all-tablesscans every row even when the bulk (e.g. ~197K postmeta) has no URLs. Would need an opt-in table filter.000right after import+flush; an optional--verifycurl-with-retry (or a "large imports need a moment" note) would set expectations.~/db-backup-*.sql.gz; adb backups list/pruneverb would manage accumulation.Tests
scpUploadasserts-C;spinner()emits a stderr marker in non-TTY and stays silent in JSON mode.tscclean.Builds on the merged round-1/2 work (#1–#12, shipped in
0.0.1-beta.24).🤖 Generated with Claude Code