fix: support legacy CUDA graph instantiate#26
Closed
voltjia wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GraphInstantiate(GraphExec*, Graph)runtime API while compiling against CUDA-compatible runtimes that expose either the newer two-argumentcudaGraphInstantiatesignature or the legacy five-argument signature.src/native/cuda/nvidia/runtime_.handsrc/native/cuda/iluvatar/runtime_.h.Motivation
InfiniTensor/InfiniOps#790 fails in the Iluvatar unit CI after InfiniRT PR #9 because the job installs InfiniRT from
masterand builds with CoreX 4.3 / CUDA 10.2-compatible headers. In that environment,cudaGraphInstantiateis declared as:The generated InfiniRT dispatch validates and calls
GraphInstantiate(GraphExec*, Graph), so the previous direct forwarding lambda fails to compile against those headers.Related: #25 fixes the same downstream CI failure by removing unverified Iluvatar graph support. This PR is the alternative path if maintainers want to keep the Iluvatar graph API exposed and fix the compile-time signature mismatch instead.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
clang-format,ruff, and docs build passed.cmake, a C++ compiler, CUDA, or the Iluvatar CoreX SDK in PATH.Full `pytest` output (optional)
Benchmark / Performance Impact
N/A - this is a compile-time compatibility fix for graph runtime API forwarding.
Notes for Reviewers