Apply requested ordering to only to new cursors#1555
Open
annehaley wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue in Sentry has been occurring since the introduction of the
PinnedFirstPaginationclass. The errorValueError("Cursor position does not match the current ordering.")is raised when an existing cursor is later passedpin_sort=True. This PR adjusts the logic inpaginate_querysetsuch that we only adjust the ordering if we are creating a new cursor (ifpagination.cursor.positionis None). If the cursor already has a position, continue with the same ordering regardless of whetherpin_sort=Trueis present in the current request.This PR also adds a test to confirm that the error is no longer raised if we try to change the ordering on an existing cursor.