Skip to content

fix(elt-common): m365 client type errors - #431

Merged
WHTaylor merged 1 commit into
mainfrom
m365_client_type_errors
Aug 14, 2026
Merged

fix(elt-common): m365 client type errors#431
WHTaylor merged 1 commit into
mainfrom
m365_client_type_errors

Conversation

@WHTaylor

Copy link
Copy Markdown
Contributor

I was experimenting with type checking as part of #430, and ty flagged basically 3 categories of errors in elt-common:

  1. The couple fixed here
  2. Problems from dependencies (e.g. the pyarrow.compute functions don't seem to be exposed to the type checker correctly)
  3. Problems in the dlt_sources and dlt_destinations packages, which will be removed fairly soon anyway (after we migrate prod to Replace dlt framework and overhaul ingestion code #321)

Will hopefully look into 2 separately at some point. If we resolve that, and remove the dlt stuff, we could then integrate typechecking as part of CI for an extra safety net.

@WHTaylor
WHTaylor requested a review from a team as a code owner August 13, 2026 16:57
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@WHTaylor, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 102 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dabfdceb-3cad-4067-8f38-29baa5d56ce0

📥 Commits

Reviewing files that changed from the base of the PR and between 5372b6c and efbc41a.

📒 Files selected for processing (1)
  • elt-common/src/elt_common/sources/m365/client.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@martyngigg martyngigg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Making good strides towards #231.

As you identified , dlt was causing quite a lot of trouble for ty so it'll be nice to be able to implement this.

@WHTaylor
WHTaylor merged commit 56c56d8 into main Aug 14, 2026
4 checks passed
@WHTaylor
WHTaylor deleted the m365_client_type_errors branch August 14, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants