fix(elt-common): m365 client type errors - #431
Conversation
|
Warning Review limit reached
Next review available in: 102 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
martyngigg
left a comment
There was a problem hiding this comment.
Nice. Making good strides towards #231.
As you identified , dlt was causing quite a lot of trouble for ty so it'll be nice to be able to implement this.
I was experimenting with type checking as part of #430, and
tyflagged basically 3 categories of errors inelt-common:pyarrow.computefunctions don't seem to be exposed to the type checker correctly)dlt_sourcesanddlt_destinationspackages, which will be removed fairly soon anyway (after we migrate prod to Replace dlt framework and overhaul ingestion code #321)Will hopefully look into 2 separately at some point. If we resolve that, and remove the
dltstuff, we could then integrate typechecking as part of CI for an extra safety net.