'API inconsistency for release time between JsonParser and JsonPrinter#12320
Open
stevenwinship wants to merge 2 commits into
Open
'API inconsistency for release time between JsonParser and JsonPrinter#12320stevenwinship wants to merge 2 commits into
stevenwinship wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
April 15, 2026 18:40
67a334d to
28c4875
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
April 16, 2026 22:37
28c4875 to
9aa5071
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
April 20, 2026 22:15
9aa5071 to
6f130f7
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
April 23, 2026 15:51
6f130f7 to
48ed227
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
April 27, 2026 13:11
48ed227 to
85dc51a
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
April 30, 2026 13:16
85dc51a to
e4b0fed
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
May 2, 2026 14:13
e4b0fed to
2066c4b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
June 9, 2026 20:06
6a25ed4 to
782c032
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
June 15, 2026 21:17
782c032 to
3bee1b4
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
June 22, 2026 17:41
3bee1b4 to
5bdacc2
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
July 2, 2026 13:13
5bdacc2 to
f703984
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
July 2, 2026 20:45
f703984 to
19a1bb3
Compare
This comment has been minimized.
This comment has been minimized.
rtreacy
approved these changes
Jul 6, 2026
rtreacy
left a comment
Contributor
There was a problem hiding this comment.
Claude
Overall this is a small, well-targeted, backward-compatible fix with adequate test coverage.
Two minor findings (neither blocking):
- The new test shadows the class field sut (the actual JsonParser under test) with an unrelated local String sut = "foobar", and redundantly re-instantiates a parser/mocks instead of reusing the existing sut field from @beforeeach — just a readability/duplication nit.
- The release note has two typos ("preferance" → "preference", "continue to truncated" → "continue to be truncated").
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
July 9, 2026 17:34
7cb2b45 to
42bd8c8
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
July 13, 2026 18:09
42bd8c8 to
c7b90b5
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
July 22, 2026 15:36
c7b90b5 to
0bba3db
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11594-release-time-inconsistency-api
branch
from
July 22, 2026 21:11
0bba3db to
0c22d29
Compare
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The output of JsonPrinter includes "releaseTime" where the input to JsonParser only accepted "releaseDate"
Which issue(s) this PR closes:#11594
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: