fix jsf guestbook response cancel button#12220
Open
stevenwinship wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
Size: 10
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
|
Coverage is 24.974% — 12205-guestbook-response-jsf-popup-cancel-button into develop. No base build found for |
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
3 times, most recently
from
April 6, 2026 19:34
f30e3dc to
1a99b0f
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
3 times, most recently
from
April 15, 2026 18:41
2ff633a to
70a5914
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
3 times, most recently
from
April 21, 2026 15:19
2cc838e to
90106cd
Compare
sekmiller
approved these changes
Apr 23, 2026
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
from
April 23, 2026 16:12
90106cd to
61899b0
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
2 times, most recently
from
May 11, 2026 13:12
13629da to
a2b8ea3
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
from
May 13, 2026 13:10
75670c0 to
6bbcc8a
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
from
May 20, 2026 14:05
6bbcc8a to
a87491e
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
2 times, most recently
from
May 26, 2026 17:55
fae6525 to
76c1677
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
4 times, most recently
from
June 1, 2026 20:49
bcdc62c to
b25ee99
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
from
June 3, 2026 15:02
b25ee99 to
bbdec41
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
3 times, most recently
from
June 15, 2026 12:59
48cd921 to
c946091
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
2 times, most recently
from
June 15, 2026 21:16
180efc7 to
aa3b085
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
from
June 22, 2026 17:41
aa3b085 to
7ea003d
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
from
July 1, 2026 18:49
7ea003d to
129c382
Compare
qqmyers
reviewed
Jul 1, 2026
| jsf:rendered="#{!empty workingVersion.termsOfUseAndAccess.disclaimer}"> | ||
| <label jsf:for="fdDisclaimer" class="col-sm-3 control-label"> | ||
| #{bundle['file.dataFilesTab.terms.list.termsOfUse.addInfo.disclaimer']} | ||
| jsf:rendered="#{!empty workingVersion.termsOfUseAndAccess.termsOfAccess and (hasRestrictedFile or !empty fileDownloadHelper.filesForRequestAccess)}"> |
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
from
July 6, 2026 14:20
a4b17ac to
9bb9f05
Compare
stevenwinship
force-pushed
the
12205-guestbook-response-jsf-popup-cancel-button
branch
from
July 22, 2026 15:36
9bb9f05 to
4d4ab04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Pressing 'Cancel' button on JSF Guestbook Response screen (preview, download, or request access) does not cancel the dialog
Which issue(s) this PR closes:#12205
Special notes for your reviewer: lines prior to 291 are just reformatted because the spacing was off. No code changes were made. The new code comes after line 291
Suggestions on how to test this: Make a dataset require a guestbook response. Try to preview the file. Try to download the file. Also with dataverse.files.guestbook-at-request=true try to request access to a restricted file. Old version - cancel does nothing. This version - Cancel closes the tab/dialog and returns you to the files tab.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: