Skip to content

Alert-system: Map to internal cluster eoapi url - #2773

Draft
sandeshit wants to merge 3 commits into
developfrom
feat/url-remap
Draft

Alert-system: Map to internal cluster eoapi url#2773
sandeshit wants to merge 3 commits into
developfrom
feat/url-remap

Conversation

@sandeshit

Copy link
Copy Markdown
Contributor

Changes

  • Map external urls for related events to internal cluster eoapi url.
  • Avoid raise on empty data.

Checklist

  • Updated/ran unit tests
  • Updated CHANGELOG.md

NOTE

  • This is a breaking change in staging environment.

@sandeshit
sandeshit marked this pull request as draft July 1, 2026 06:07
@sandeshit
sandeshit force-pushed the feat/url-remap branch 2 times, most recently from e7bfb81 to 925387c Compare July 31, 2026 06:19
- Remap urls to internal cluster urls.
- Remove explicit failures on empty event data.

@susilnem susilnem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeshit Can you verify this changes?

Comment thread alert_system/helpers.py Outdated
Comment on lines +26 to +27
if ext.path and path.startswith(ext.path):
path = path[len(ext.path) :]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be something like this?

Suggested change
if ext.path and path.startswith(ext.path):
path = path[len(ext.path) :]
if ext.path and (path == ext.path or path.startswith(ext.path + "/")):
path = path[len(ext.path):]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants