Skip to content

Fix UB in hash implementation#84

Merged
Enchufa2 merged 5 commits into
masterfrom
patch
Jul 17, 2026
Merged

Fix UB in hash implementation#84
Enchufa2 merged 5 commits into
masterfrom
patch

Conversation

@Enchufa2

Copy link
Copy Markdown
Member

As reported by CRAN:

nn2poly_types.h:25:27: runtime error: signed integer overflow: 73243494 * 73244475 cannot be represented in type 'int'
      #0 0x7b59bd7d8a34 in TermHash::operator()(std::__1::vector<int, std::__1::allocator<int>> const&) const /__w/nn2poly/nn2poly/check/nn2poly.Rcheck/00_pkg_src/nn2poly/src/./nn2poly_types.h:25:27

etc. Some other minor fixes here and there now that we're at it.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.92%. Comparing base (4cdc4c1) to head (a655bfb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   83.90%   83.92%   +0.02%     
==========================================
  Files          18       18              
  Lines         758      759       +1     
==========================================
+ Hits          636      637       +1     
  Misses        122      122              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enchufa2

Copy link
Copy Markdown
Member Author

New checks are clean, merging.

@Enchufa2
Enchufa2 merged commit 97c6c8f into master Jul 17, 2026
17 checks passed
@Enchufa2
Enchufa2 deleted the patch branch July 17, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant