fast paths for ccsid 1208 - #334
Open
mdg1349 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matteo Di Liberto Gasparin <matteo.diliberto@sanmarcoinformatica.it> Signed-off-by: mdg1349 <142481417+mdg1349@users.noreply.github.com>
mdg1349
force-pushed
the
fast_path_ccsid_1208
branch
from
July 27, 2026 14:48
fe67852 to
1c0e576
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, i made some changes regarding the conversion table for CCSID 1208 to use normal JVM string functions for speed and simplicity. The new code paths are only activated if fault tolerant conversions are disabled (which is the default).
BOB gave me a hand in investigating the issue, so I'll report some of its musings:
Code Organization
Benefits
Why This Matters
CCSID 1208 is UTF-8, one of the most common character encodings. Most applications don't need fault-tolerant conversion, so this optimization benefits the majority of use cases while preserving special handling for those who need it.