Skip cross-repo round-trip when the sibling buyer repo is absent (fresh clone pytest fails)#25
Open
aleksUIX wants to merge 1 commit into
Conversation
test_round_trip_builder_then_parser_recovers_refs raised RuntimeError on any standalone clone: it walks parents looking for a directory named ad_seller_system (a default clone is named seller-agent) and then needs a sibling ad_buyer_system checkout. Fresh clone plus pytest failed out of the box; CI only stays green because ci.yml checks out buyer-agent and sets AD_BUYER_SRC_PATH. Ports the fix buyer-agent merged in PR #92 for its mirror-image test: skip instead of raise when the seller repo root cannot be located, and skip when the resolved buyer src directory does not exist. The test still runs when AD_BUYER_SRC_PATH is set or the sibling layout exists; verified both ways (skips on a standalone clone, passes with AD_BUYER_SRC_PATH pointing at a buyer checkout).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A fresh
git clone+pip install -e ".[dev]"+pytest tests/unitfails out of the box:The cross-repo round-trip test walks parent directories looking for one literally named
ad_seller_system(a default clone is namedseller-agent), then needs a siblingad_buyer_systemcheckout. CI stays green only becauseci.ymlchecks out buyer-agent and setsAD_BUYER_SRC_PATH; every standalone contributor clone gets a red suite.buyer-agent hit the mirror image of this and fixed it in buyer-agent#92 ("Skip cross-repo audience plan round-trip when sibling repos absent"). This PR ports that exact pattern:
src/directory does not exist (partial checkout)Verification
SKIPPED, file exit code 0, 12 others pass.AD_BUYER_SRC_PATHpointing at a real buyer-agent checkout'ssrc/, the round-trip runs and passes.ruff checkclean.