fix: Remove dead module io_storages/filesystem.py (#9815) - #9821
Open
johntomcat7408-cmyk wants to merge 2 commits into
Open
fix: Remove dead module io_storages/filesystem.py (#9815)#9821johntomcat7408-cmyk wants to merge 2 commits into
johntomcat7408-cmyk wants to merge 2 commits into
Conversation
…arget was dropped in the 1.0.0 rewrite (HumanSignal#9815)
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for label-studio-playground canceled.
|
✅ Deploy Preview for label-studio-storybook canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
label_studio/io_storages/filesystem.pyimportsBaseForm,BaseStorageandCloudStoragefromio_storages/base.py, which does not exist; the classes are notdefined anywhere in the codebase, so importing the module raises
ModuleNotFoundError.The import has been broken since the 1.0.0 rewrite (#652), which moved
storage/filesystem.pytoio_storages/filesystem.pybut deletedstorage/base.pyin the same commit. Nothing imports the module —
io_storages/__init__.pyis empty,io_storages/models.pyonly imports the azure_blob/s3/gcs/redis submodules, and arepo-wide search finds no references to the module or to any of the five classes it
defines. Its functionality is covered by
io_storages/localfiles/and the ORM modelsin
base_models.py. This removes the file instead of fixing the import, because themissing base classes belong to the removed Flask-era storage layer.
Fixes #9815.
Brief change log
label_studio/io_storages/filesystem.py(−281 lines, no other changes).Verifying this change
python -c "import io_storages.filesystem"raisesModuleNotFoundError: No module named 'io_storages.base'.import io_storagessucceeds; no runtime code path loads the removed module,so behavior is unchanged.