Render structured claim summary answers (RND-2030) - #3019
Merged
Conversation
hugokallstrom
marked this pull request as ready for review
July 14, 2026 11:48
StylianosGakis
approved these changes
Jul 29, 2026
Member
There was a problem hiding this comment.
Regarding the
else -> {
logcat { "SummaryFragment.Answer: Unknown answer value type" }
raise(ClaimChatErrorMessage.NeedsUpdate)
}
When the answer is not of a known value, this I think would error out the entire screen, which if we do make such a change might be a bit too much.
How would we feel if we just ignored such unknown values, logged it, and did not render anything there, just rendering whatever else is available anyway to prevent blocking the rest of the content from showing?
I think the val freeTexts: List, part of data class Summary is now completely unused too, perhaps we can clean that part up if it’s not going to be used.
Backend adds structured keyDetails/answers (Text/Audio/Files union) to ClaimIntentStepContentSummary. Hand-add the identical SDL to the local schema (dev router doesn't have it yet), extend SummaryFragment, StepContent.Summary, and the union mapping so the data layer is ready for the UI to consume. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Render the collapsed "Claim details" card from the structured keyDetails, add a "Show all answers" control that opens a HedvigBottomSheet listing each answer (text / inline audio player / files), and keep the existing Recording and Uploaded files sections. Falls back to items when keyDetails is empty so older backend responses do not regress. Adds a jvmTest ImageComposeScene render harness for PNG verification (KMP modules are unsupported by the AGP screenshot plugin) and a no-op JVM CommonMediaPlayer so audio-backed composables render headlessly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Outline the show-all-answers button, hide the audio transcript, and use 16dp top spacing above the button. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Add a full-width secondary Close button at the bottom of the answers sheet (dismisses it), and give the header title more top spacing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
An unknown answer value type raised NeedsUpdate from inside toStepContent, which aborts mapping for the whole claim intent and errors out the entire screen. The summary is a read-only recap, so drop just that answer and render whatever else came back. Logged at WARN since it is now a silent degradation. Also drop freeTexts: the answers sheet replaced the free-text pill list, so the field was selected and mapped but never read. Free-text answers now arrive as Answer.Value.Text. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
hugokallstrom
force-pushed
the
feat/claim-summary-structured-answers
branch
from
July 29, 2026 09:06
6b37cf5 to
8913722
Compare
hugokallstrom
enabled auto-merge (squash)
July 29, 2026 09:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The claims-service summary step now exposes
keyDetails(facts for a collapsed"Claim details" card) and
answers(ordered question/answer pairs whose value isa Text / Audio / Files union), for the new "claims-flow-new" summary UI. Today the
Android summary renders one flat, always-expanded card, so it can't show the new
collapsed card + per-question answers (with inline audio playback).
What
SummaryFragmentselects the newkeyDetailsandanswersfields;StepContent.Summarygains
keyDetails+answers(with anAnswer.Value= Text/Audio/Files model), mappedin
ClaimIntentExt.ChatClaimSummaryTopContentrenders a collapsed "Claim details" card fromkeyDetails(falling back to
itemswhen empty) plus a "Show all answers" button — shown only whenanswersis non-empty — that opens aHedvigBottomSheetlisting each question with itsanswer inline (text, a
HedvigAudioPlayerfor recorded answers, or files). The existingRecording and Uploaded-files sections are unchanged.
claim_status_show_all_answersstring.🤖 Generated with Claude Code