Document threads.preload config option#561
Draft
kriszyp wants to merge 2 commits into
Draft
Conversation
Adds threads.preload to the configuration reference — preloads modules (e.g. dd-trace) via --require on worker threads before any Harper or app module, for APM/instrumentation agents. Ships in harper v5.2.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds documentation for the new preload configuration option under threads in reference/configuration/options.md. The reviewer suggested restructuring the YAML example to avoid duplicate keys within the same block, which could lead to invalid YAML if uncommented.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-561 This preview will update automatically when you push new commits. |
Avoids a duplicate 'preload' key in one block (would be invalid YAML if the commented lines were uncommented). Addresses docs review. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-561 This preview will update automatically when you push new commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the new
threads.preloadconfiguration option in the config reference.threads.preloadloads a module (or list of modules) via Node's--requirebefore any Harper or application module on each worker thread — the earliest point in a worker's lifetime — so instrumentation/APM agents likedd-tracecan instrument subsequent module loads. Bare specifiers resolve against installed components'node_modules; absolute paths are also accepted.Companion PR
Core implementation: HarperFast/harper#1569.
Notes for the reviewer
<VersionBadge version="v5.2.0" />on the assumption this ships in core v5.2.0 (main is currently on 5.1.15). Please adjust the version if it lands in a different release.Generated with assistance from Claude (Opus 4.8); reviewed and committed by Kris.