Skip to content

Use hostname in controlled-flow replication example#555

Open
kriszyp wants to merge 1 commit into
mainfrom
kris/498-controlled-flow-docs
Open

Use hostname in controlled-flow replication example#555
kriszyp wants to merge 1 commit into
mainfrom
kris/498-controlled-flow-docs

Conversation

@kriszyp

@kriszyp kriszyp commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary

The "Controlling Replication Flow" example in reference/replication/overview.md used host:, while the rest of the page (and the config schema) use hostname:. Both are accepted, but the inconsistency is confusing. Switched the example to hostname:.

Context

Companion to the controlled-flow enforcement work for harper-pro#498 (HarperFast/harper-pro#506) and the schema validation that makes these fields first-class (HarperFast/harper#1529).

Generated by an LLM (Claude Opus 4.8).

🤖 Generated with Claude Code

The "Controlling Replication Flow" example used `host:` while the rest of the
doc and the schema use `hostname:` (both are accepted). Reconcile for
consistency. Relates to harper-pro#498.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the replication overview documentation by changing the configuration key from host to hostname in the YAML examples. There are no review comments, and I have no additional feedback to provide.

@github-actions

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-555

This preview will update automatically when you push new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants