fix(formit): игнорировать пустые ошибки полей#14
Open
Ibochkarev wants to merge 1 commit into
Open
Conversation
FormIt can set fi.error.* to whitespace or empty HTML wrappers. Treat these as no error via getSanitizedPlaceholder() on the server and hasErrorMessage() on the client. Fixes GulomovCreative#10
Ibochkarev
marked this pull request as ready for review
July 13, 2026 10:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormIt иногда выставляет
fi.error.email(и другиеfi.error.*) в пробелили HTML-обёртку вроде
<span class="error"> </span>, даже когда полевалидно.
handleFormIt()проверял placeholder черезisset(), whitespaceпопадал в
$errors, и AJAX-ответ уходил сsuccess: false.На сервере добавлен
getSanitizedPlaceholder():html_entity_decode,strip_tags,trim. В$errorsпопадают только непустые сообщения.Тот же путь для
validation_error_messageи recaptcha.На клиенте
hasErrorMessage()фильтрует пустые значения в цикле ошибоки в
setError(). Текст ошибки пишется черезtextContent, неinnerHTML.Fixes #10