fix[next]: keep scan compute domain within the statement colum#2709
Open
SF-N wants to merge 1 commit into
Open
fix[next]: keep scan compute domain within the statement colum#2709SF-N wants to merge 1 commit into
SF-N wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A scan computes its entire vertical column sequentially and cannot read its inputs outside that column. When a scan's result is read at a vertical offset — e.g. a backward scan reading a forward scan's result at
Koff[-2]— domain inference back propagated that offset and extended the scan's compute domain (to[-2, 11)instead of[0, 11)). The scan then reads its inputs out of bounds.This was fixed by making
_infer_stmtnow derive the statement's vertical column and thread it (scan_vertical_bounds) throughinfer_expr. When a scan's vertical dimension is re-added to its domain, the range is taken from that column rather than from the (offset-extended) back-propagated domain, so every scan in aSetAtis pinned to the statement column. All fields written by aSetAtshare one vertical column, so any concrete target domain is representative of it.A new unit test
test_scan_result_vertical_offsetwith a fused forward/backward scan program where the backward scan reads the forward result atKoff[-2]was added.