refactor[cartesian]: descriptive loop names in dace backend#2683
Merged
Conversation
Contributor
Author
|
cscs-ci run |
Contributor
Author
|
cscs-ci run default |
2 tasks
twicki
approved these changes
Jul 8, 2026
twicki
left a comment
Contributor
There was a problem hiding this comment.
It makes sense to carry this information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The pipeline of representations (truncated) for the cartesian dace backend is as follows:
In this PR, we change the names of map/loop in the schedule tree representation. The map/loop names in that representation are just names (that can more or less be anything). We had a rather general description and replace it with a more descriptive one, which includes the name of the stencil where the horizontal/vertical loop (sections) come from. This allows easier debugging and profiling. Nothing (except names) changes in the generated code. Thus no tests have been added.
This PR contains an unrelated commit removing unused imports from dace backend tests.
This PR is part of cleaning up our "working branch", i.e. #2595, which accumulated a couple of changes over the last month.
Requirements
N/A
N/A