Skip to content

refactor[cartesian]: descriptive loop names in dace backend#2683

Merged
romanc merged 2 commits into
GridTools:mainfrom
romanc:romanc/descriptive-loop-names
Jul 8, 2026
Merged

refactor[cartesian]: descriptive loop names in dace backend#2683
romanc merged 2 commits into
GridTools:mainfrom
romanc:romanc/descriptive-loop-names

Conversation

@romanc

@romanc romanc commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

The pipeline of representations (truncated) for the cartesian dace backend is as follows:

... > oir -> treeir (gt4py) -> schedule tree (dace) -> SDFG (dace)

In this PR, we change the names of map/loop in the schedule tree representation. The map/loop names in that representation are just names (that can more or less be anything). We had a rather general description and replace it with a more descriptive one, which includes the name of the stencil where the horizontal/vertical loop (sections) come from. This allows easier debugging and profiling. Nothing (except names) changes in the generated code. Thus no tests have been added.

This PR contains an unrelated commit removing unused imports from dace backend tests.

This PR is part of cleaning up our "working branch", i.e. #2595, which accumulated a couple of changes over the last month.

Requirements

  • All fixes and/or new features come with corresponding tests.
    N/A
  • Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.
    N/A

@romanc
romanc requested a review from twicki July 2, 2026 13:38
@romanc

romanc commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

cscs-ci run

@romanc

romanc commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

cscs-ci run default

@twicki twicki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to carry this information

@romanc
romanc merged commit d0f4728 into GridTools:main Jul 8, 2026
20 checks passed
@romanc
romanc deleted the romanc/descriptive-loop-names branch July 8, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants