perf[cartesian]: avoid x + 0 and 0 + x expression in index bounds#2682
Merged
Conversation
The conditionals for regions were generated in the form of
`{axis_bound} + {offset}`. This would lead to conditionals like
```cpp
if (((__i >= (0 + -1)) && (__i < (0 + 0)))) { ... }
```
in generated code. While we could expect compilers to handle this, it's
also ugly to work with in the intermediate representations.
This PR suggests - as a first, easy step - to detect `0` and not write
them.
twicki
approved these changes
Jul 8, 2026
twicki
left a comment
twicki
left a comment
Contributor
There was a problem hiding this comment.
That works! Even covering for the niece end=0 case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In oir -> treeir, avoid inserting artificial
x + 0or0 + xcalculations when translating axis bounds. In the end, this makes for cleaner generated code, which is easier to read and doesn't rely on general compilers to remove the calculation as part of their optimization pipeline.This PR is part of cleaning up our "working branch", i.e. #2595, which accumulated a couple of changes over the last month.
Requirements
N/A