fix(ci): green the 5 stale dev tests (orphaned bridge + post-#257 logger snapshot)#262
Closed
AlexGrayBox wants to merge 1 commit into
Closed
fix(ci): green the 5 stale dev tests (orphaned bridge + post-#257 logger snapshot)#262AlexGrayBox wants to merge 1 commit into
AlexGrayBox wants to merge 1 commit into
Conversation
…ger snapshot) Two independent clusters have been red on dev's Code CI for many commits — both stale tests left behind by removed features, not real bugs: A) ui_docker_bridge: f45510b ('Docker-free UI') renamed ui_docker_bridge.py -> cli.py and moved cert scripts to ui/utils/, but a later merge re-added the orphaned ui_docker_bridge.py (imported by nothing, pointing at deleted docker/docker/utils/ paths + a build-and-deploy.sh that no longer exists). cli.py + test_cli.py (29 green) supersede it -> delete the dead file + test. B) logger snapshot: 671270b (#257) replaced the chunked-zstd logger snapshot with DuckDB (loggers.duckdb via flush_logger_to_disk), removing save_logger_snapshot but leaving its tests + one caller behind: - repoint test_logger_queue_saved_with_weights to assert loggers.duckdb - delete test_logger_snapshot_rotation (tested only the removed writer) - experiment_service: note-persist path guarded hasattr(save_logger_snapshot) -> always False -> notes silently not persisted; swap to flush_logger_to_disk Verified: repointed test passes against DuckDB; test_checkpoint_workflow 15/15; test_cli 29/29; full suite collects 1075 clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent clusters of tests have been red on dev's Code CI for many commits — both are stale tests left behind by removed features, not real bugs. Diagnosed + verified locally.
Cluster A — orphaned
ui_docker_bridge.py(3 tests)f45510b("Docker-free UI") renamedui_docker_bridge.py→cli.pyand moved cert scripts toui/utils/. A later merge re-added the orphanedui_docker_bridge.py— imported by nothing, still pointing at deleteddocker/docker/utils/paths and abuild-and-deploy.shthat no longer exists anywhere. The livecli.py+test_cli.py(29 green) fully supersede it.weightslab/ui_docker_bridge.py+tests/backend/test_ui_docker_bridge.py.Cluster B —
save_logger_snapshotremoved by #257's DuckDB migration (2 tests + 1 caller)671270b(#257) replaced the chunked-zstd logger snapshot with DuckDB (loggers.duckdbviaflush_logger_to_disk, fully wired incheckpoint_manager). It removedsave_logger_snapshotbut left its tests + one caller behind.test_logger_queue_saved_with_weights→ assertloggers.duckdbexists + read the live logger (instead of the oldloggers.manifest.json/chunks).test_logger_snapshot_rotation.py(tested only the removed chunked-zstd writer).experiment_service.py: the note-persist path guardedhasattr(cm, "save_logger_snapshot")→ always False on dev → note edits were silently not persisted. Swapped toflush_logger_to_disk().Verification (local)
test_checkpoint_workflow.py15/15;test_cli.py29/29; full suite collects 1075 clean (deletions break no imports).experiment_servicecaller fix; no coverage lost (cli.py/test_cli.pycover the bridge behavior correctly).Impact
Greens dev's Code CI. Also unblocks #261 (per-cell loss trajectory), which is only red because it inherits these same 5 failures — it'll go green once this lands and #261 rebases.
🤖 Generated with Claude Code