feat: add winners section#24
Open
satasatalight wants to merge 2 commits into
Open
Conversation
satasatalight
requested review from
StevScripts,
alecocosette and
sebastian-noel
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This implementation is a little overkill but it assumes the worst case scenario for receiving data from the backend.
The component receives an unsorted array of all past winners. It filters down to all entries from the most recent deadline and sorts by placement for the top "WinnerCard" components and places the rest of the elements in the lower "PrevWinnerEntry" list sorted by deadline. The component assumes the projectTitles for each winner entry are unique, using that field as a key. Initials for the WinnerCard component are collected using a regex pattern match on a name field.
Type of Change
feat: New featurefix: Bug fixchore: Maintenance (dependencies, config, etc.)docs: Documentation onlystyle: Code style (formatting, no logic change)refactor: Code refactor (no new feature or fix)Changes Made
Screenshots (if applicable)
Checklist
npm run lintpasses without errorsnpm run buildcompletes successfullyRelated Issues
Closes Notion task "T11 (Challenges) - Build winners components"