feat: add carousel component#23
Open
cunkin375 wants to merge 5 commits into
Open
Conversation
Removed unused setCardSource function from ImageCarousel.
Collaborator
Author
|
Currently in ImageCarousel.tsx:150, the use of Image expects CarouselCard objects to hold valid sources to images. If this is not the case, the current code does not fallback to any default images/DOM elements. I will fix this when I have the time, but if anyone is able handle this prior to merging, that would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds ImageCarousel component and uses it in AboutSection.tsx.
Type of Change
feat: New featurefix: Bug fixchore: Maintenance (dependencies, config, etc.)docs: Documentation onlystyle: Code style (formatting, no logic change)refactor: Code refactor (no new feature or fix)Changes Made
Screenshots (if applicable)
feature_add-carousel-component.mp4
Checklist
npm run lintpasses without errorsnpm run buildcompletes successfullyRelated Issues