Skip to content

feat: add carousel component#23

Open
cunkin375 wants to merge 5 commits into
mainfrom
feature/add-carousel-component
Open

feat: add carousel component#23
cunkin375 wants to merge 5 commits into
mainfrom
feature/add-carousel-component

Conversation

@cunkin375

Copy link
Copy Markdown
Collaborator

Pull Request

Description

Adds ImageCarousel component and uses it in AboutSection.tsx.

Type of Change

  • feat: New feature
  • fix: Bug fix
  • chore: Maintenance (dependencies, config, etc.)
  • docs: Documentation only
  • style: Code style (formatting, no logic change)
  • refactor: Code refactor (no new feature or fix)

Changes Made

  • Add ImageCarousel.tsx
  • Implement ImageCarousel component in AboutSection.tsx with static cards

Screenshots (if applicable)

feature_add-carousel-component.mp4

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have tested my changes locally
  • npm run lint passes without errors
  • npm run build completes successfully

Related Issues

Removed unused setCardSource function from ImageCarousel.
@cunkin375

Copy link
Copy Markdown
Collaborator Author

Currently in ImageCarousel.tsx:150, the use of Image expects CarouselCard objects to hold valid sources to images. If this is not the case, the current code does not fallback to any default images/DOM elements. I will fix this when I have the time, but if anyone is able handle this prior to merging, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant