Fix scheduled date handling in recurring tasks#4144
Conversation
The "scheduled" attribute of tasks generated by recurring tasks is now updated the same way the "wait" attribute is handled. The difference between the original "scheduled" and "due" dates is added to the "due" date of each generated task when a "scheduled" date is present.
ashprice
changed the title
Signed-off-by: ashprice <gitcommit1@sl.ashprice.co.uk>
|
Didn't look at the current state close enough and missed that. Sorry! |
|
Not sure of the cause of the failing test. I can't recreate it... |
|
It's quite possible that was an intermittent failure -- that test seems a little suspect. I've re-run it! |
|
Green! |
e0bd13c
into
GothenburgBitFactory:develop
|
Great! This change should probably be accompanied by a PSA and a news announcement in the next release, because it will likely break hooks that people have used to address the inconsistency. |
We actually have a "news" feature for that -- |
3 participants
Subset from PR #3006 without the changes to
until.Closes #2414, #97, #3823, part of #1534.
#1983 is mostly covered by
untilby usinguntil:now+someperiodoruntil:date, the main thing missing there would beuntil:some-task-count. I could probably implement that behaviour, but I think it might be better to wait for iterative tasks to land?