okf: resolve absolute (bundle-relative) links in the visualizer - #206
Open
larsappel wants to merge 1 commit into
Open
okf: resolve absolute (bundle-relative) links in the visualizer#206larsappel wants to merge 1 commit into
larsappel wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
SPEC §5.1 supports links beginning with "/", interpreted relative to the bundle root, but _extract_links skipped them alongside external URLs, so bundles using the absolute link style rendered with zero edges. Resolve them against the bundle root instead; relative links are unchanged.
larsappel
force-pushed
the
fix/visualizer-absolute-links
branch
from
July 17, 2026 12:01
11f8a63 to
58d3947
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
_extract_linksin the viewer generator skipped any link target beginning with/, treating it like an external URL. But SPEC §5.1 explicitly supports the absolute (bundle-relative) link form — "Begin with/, interpreted relative to the bundle root" — so a spec-conformant bundle using that style renders with zero edges in the visualizer.This resolves
/-prefixed targets against the bundle root; relative links are unchanged, external URLs are still skipped.Why it matters
The absolute style is the one the spec recommends for links that should survive files being moved within their subdirectory, so bundles that follow that advice currently lose their entire graph. Found while visualizing a personal 42-concept bundle that uses absolute links throughout: 0 edges before this patch, 110 after.
Test
Added
test_absolute_links_become_edgesalongside the existing link tests (mixed absolute links, including one with a#fragment). Fulltest_viewer.pysuite passes: 7 passed.🤖 Generated with Claude Code