You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CopilotAI
changed the title
[WIP] Research browser translation support alongside localized UI
Enable browser translation for localized routes
Jul 23, 2026
also, is there any reason why this was chosen to be disabled? what it would prevent or fix?
Removed the generated skills-lock.json in commit c0c3a1d. The original translate="no" was likely intended to prevent automatic translation from changing wallet-critical identifiers or code-like values (addresses, token symbols, amounts, hashes, and links), and to avoid mixed built-in/browser translations. It also disabled browser translation for all visible UI text, including unsupported-language users, so the document-wide opt-out was removed. Critical values should instead use narrowly scoped translate="no" attributes where needed.
@copilot So can you go over the wallet and apply where needed the attribute to prevent critical information to be translated
Applied narrowly scoped translate="no" guards in 0d2cbd1 across portfolio balances/token symbols, activity amounts/addresses/hashes, receive and account addresses, recipient and WalletConnect URI inputs, send/swap amounts and confirmations, and GoodDollar claim/invite values. Localized labels, disclaimers, and other user-facing copy remain eligible for browser translation. Biome and the full Vitest suite pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoodWallet’s document-wide translation opt-out prevented browser translation for unsupported languages. The change preserves built-in English/Danish localization while allowing browser translation services to translate visible UI.
lang="en"and no longer setstranslate="no"./enor/daroute updates the document language client-side: