Added param 'keep_image_size' to resize depth image and keep original…#30
Merged
Merged
Conversation
Contributor
|
Looks good, thanks @JEDominguezVidal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… RGB image size
Description
Added param 'keep_image_size' to resize depth image (and depth_colored image and confidence) in case the user wants to keep original RGB image size. Default value is false, so it is a non-breaking change which adds functionality.
Type of Change
Testing
Tested echoing topics and looking at the "height" and "width" fields of each message as well as at the size of each image itself.
Test Configuration:
Checklist
Camera-Agnostic Design
Performance Impact
Additional Notes
You already had the fuction in utils.py. Just not using it.