Skip to content

Added param 'keep_image_size' to resize depth image and keep original…#30

Merged
GerdsenAI-Admin merged 1 commit into
GerdsenAI:mainfrom
JEDominguezVidal:main
Mar 9, 2026
Merged

Added param 'keep_image_size' to resize depth image and keep original…#30
GerdsenAI-Admin merged 1 commit into
GerdsenAI:mainfrom
JEDominguezVidal:main

Conversation

@JEDominguezVidal

Copy link
Copy Markdown
Contributor

… RGB image size

Description

Added param 'keep_image_size' to resize depth image (and depth_colored image and confidence) in case the user wants to keep original RGB image size. Default value is false, so it is a non-breaking change which adds functionality.

Type of Change

  • New feature (non-breaking change which adds functionality)

Testing

Tested echoing topics and looking at the "height" and "width" fields of each message as well as at the size of each image itself.

Test Configuration:

  • OS: Ubuntu 24.04
  • ROS2 Version: Jazzy
  • Device (CPU/GPU): GPU
  • Camera (if applicable): RealSense D435i

Checklist

  • My code follows the style guidelines of this project (PEP 8, no emojis)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have maintained camera-agnostic design principles
  • I have checked my code for potential security issues

Camera-Agnostic Design

  • N/A - This PR does not involve camera integration

Performance Impact

  • No performance impact

Additional Notes

You already had the fuction in utils.py. Just not using it.

@GerdsenAI-Admin

Copy link
Copy Markdown
Contributor

Looks good, thanks @JEDominguezVidal

@GerdsenAI-Admin GerdsenAI-Admin merged commit 18bc8b0 into GerdsenAI:main Mar 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants