fix: resolve CI failures for lint, test mocking, and Docker build#19
Merged
Conversation
- Add .flake8 with Black-compatible settings (line-length 88) - Add mypy.ini with relaxed type checking for third-party imports - Add pyproject.toml with black/pycodestyle configuration - Update .gitignore to exclude .venv/ virtual environment
- Quote version specifiers in pip install commands to prevent shell interpretation issues with comparison operators
- Apply Black-compatible formatting (double quotes, trailing commas) - Improve code readability with consistent line breaks - No functional changes
- Apply Black-compatible formatting (double quotes, trailing commas) - Improve code readability with consistent line breaks - No functional changes
- Apply Black-compatible formatting (double quotes, trailing commas) - Improve code readability with consistent line breaks - No functional changes
- Remove unused Mock imports (F401) - Fix line length issues (E501) - Fix inline comment spacing (E261) - Apply Black-compatible formatting (double quotes, trailing commas)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all three CI job failures: lint violations, test mock path errors, and Docker build issues.
Changes
Lint Fixes
da3_inference_optimized.pyanddepth_anything_3_node_optimized.pytest/test_inference.pyTest Fixes
depth_anything_3_ros2.da3_inference.DepthAnything3todepth_anything_3.api.DepthAnything3(where the import actually occurs)test_inference_invalid_input_typeto use the imported classDocker Fixes
<2.0as a file redirectpip install numpy>=1.24.0,<2.0topip install "numpy>=1.24.0,<2.0"Developer Experience
.flake8config for consistent 88-char line length locallymypy.inito suppress missing import errors for optional dependencies.vscode/settings.jsonwith project-specific linting settingsTesting
All CI checks pass locally: