hotfix#16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds entry point scripts and improves the installation and packaging of node scripts for ROS2 launch compatibility in the
depth_anything_3_ros2package. The most important changes are grouped below:Node script entry points and installation improvements:
depth_anything_3_nodeanddepth_anything_3_node_optimizedin thedepth_anything_3_ros2/scriptsdirectory to provide direct executable entry points for ROS2 nodes. [1] [2]setup.pyinstallation configuration to include all scripts indepth_anything_3_ros2/scripts/underlib/<package>/, ensuring compatibility with ROS2 launch mechanisms.Packaging and setup script enhancements:
setuptoolsinsetup.pyto suppress type checking errors.setup.pydescription field for better readability.setup.pyfor consistency.