refactor(auth): use useMutation for social sign-in in LoginButton#1340
Merged
Conversation
Replaces raw .catch() chaining with useMutation to align with the codebase's established pattern for async operations and error handling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fengelniederhammer
approved these changes
Jul 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the LoginButton React component in the website/ frontend to align social sign-in with the existing React Query async pattern (via useMutation) and to ensure the component has access to a QueryClient when rendered standalone from Astro.
Changes:
- Wraps
authClient.signIn.social()in auseMutationhook and moves error handling toonError. - Exports
LoginButtonas awithQueryProvider(...)-wrapped component so React Query hooks work when mounted via Astro (client:load).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authClient.signIn.social()in auseMutationhook, replacing the raw.catch()patternonErrorcallback, consistent with how other async operations are handled in the codebasewithQueryProviderso it has access to the query clientCloses #1209
🤖 Generated with Claude Code