fix(wasap): deduplicate display labels in CovSpectrum collection mode#1329
Closed
fhennig wants to merge 1 commit into
Closed
fix(wasap): deduplicate display labels in CovSpectrum collection mode#1329fhennig wants to merge 1 commit into
fhennig wants to merge 1 commit into
Conversation
When a CovSpectrum collection contains multiple variants sharing the same
name, GsQueriesOverTime would throw because displayLabel must be unique.
Apply the same counter-suffix deduplication ('Resistance' → 'Resistance (2)')
that PR #1327 uses for the GenSpectrum collection mode.
Closes #1328
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Looks good, but we shouldn't duplicate code from #1327 - maybe we merge the other one first? |
Contributor
Author
|
#1327 will just cover this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1328
Summary
deduplicateDisplayLabelshelper fromuseWasapPageData.tsand applies it to thequeriesarray infetchCovSpectrumCollectionModeDataTest plan
npm run testinwebsite/)🤖 Generated with Claude Code