fix(deps): add nanoid override ^3.3.17 (GHSA-2v37-7h3g-55p8) - #115
Merged
Conversation
nanoid < 3.3.17 can loop indefinitely when a custom generator is called with size zero (high). It reaches us transitively at runtime through postcss (nanoid ^3.3.16), which resolved to 3.3.16. Add an npm override pinning nanoid to ^3.3.17 (resolves to 3.3.18) and regenerate the lockfile entry. Staying on the 3.x line keeps postcss's ^3.3.16 range satisfied; nanoid 4.x+ is ESM-only and outside it. Closes the only open Dependabot alert (#92).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe package override configuration now pins ChangesPackage Configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Dependabot alert #92 (high): GHSA-2v37-7h3g-55p8 — nanoid custom generators can loop indefinitely when size is zero. Vulnerable
< 3.3.17, patched 3.3.17.nanoidis transitive (runtime) via postcss (nanoid@^3.3.16) and had no override, so it sat at 3.3.16. Adds an override pinning^3.3.17— resolves to 3.3.18.Staying on 3.x is deliberate: postcss declares
^3.3.16, and nanoid 4.x+ is ESM-only and outside that range.Scope: 1 line in
package.json, 3 in the lockfile (version/resolved/integrity), regenerated withnpm install --package-lock-only --ignore-scripts— no unrelated churn. Integrity matches the registry's published hash.Summary by CodeRabbit