fix(deps): bump js-yaml override to ^4.3.1 (GHSA-5p4m-2wfm-xmqj) - #114
Merged
Conversation
js-yaml < 4.3.1 has quadratic CPU consumption in !!omap resolution (high, CVE-2026-59870). It is a transitive dev-only dependency already pinned by an npm override, but the override was ^4.2.0 which resolved to 4.3.0 — one patch below the fix. Bump the override to ^4.3.1 and regenerate the lockfile entry (npm install --package-lock-only). Staying on the 4.x line keeps transitive consumers satisfied; 5.x is a major and out of their ranges. Closes the only open Dependabot alert (#91).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesDependency Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the
js-yamlnpm override from^4.2.0→^4.3.1, closing the repo's only open Dependabot alert (#91, high severity).Why
GHSA-5p4m-2wfm-xmqj — quadratic CPU consumption in
!!omapresolution (CVE-2026-59870). Vulnerable range>= 4.0.0, < 4.3.1; patched in 4.3.1.js-yamlisn't a direct dependency — it arrives transitively (dev scope) and was already pinned by an npm override, but at^4.2.0, which resolved to 4.3.0 — one patch below the fix. Same stale-override pattern as the recentfast-urifix (#109), and the same transitive-CVE approach already used forhono,lodash,minimatch,postcss, etc.Staying on the 4.x line is deliberate:
js-yaml@5.x(currentlatest) is a major outside the ranges the transitive consumers declare.Change scope
1 line in
package.json, 3 in the lockfile (version/resolved/integrity), regenerated withnpm install --package-lock-only --ignore-scripts— nonode_moduleschanges, no unrelated dependency churn.Validation
4.3.1confirmed published; the lockfileintegritymatches the registry's published hash for 4.3.1 exactly.Summary by CodeRabbit