fix: remove dead loop in SuperFlex.forward() - #1
Open
giacomo-ciro wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuperFlex.forward()was runningself.heads(...)on every intermediate refined query inrefined_queries_list, even though only the result for the last query (outdict_list[-1]) was ever returned, probably a leftover from debugging.I was building on top of this repo, fixed the issue for my own code, and figured it was worth sharing as a quick PR.
The impact is minor, but since I'd already done the work, why not share it.
For context, on an NVIDIA RTX 2080 with batch size 4, the average runtime for a forward pass (n=100):
Hope you find this useful, and thanks for your research :)