feat: Enable aperture modifications without a full mechanics solver#3906
Draft
LilianeRA wants to merge 32 commits into
Draft
feat: Enable aperture modifications without a full mechanics solver#3906LilianeRA wants to merge 32 commits into
LilianeRA wants to merge 32 commits into
Conversation
…ult. A problem sample is defined in 'stressPathDrivenGeomechanics/'. The pressure and aperture data will be saved in the files 'fracPressure_history.hdf5' and 'fracAperture_history.hdf5'.
…ic trajectory: BartonBandisStressPathDriven.
…ePassThru function for our new constitutive law; Deleting commented function in FlowSolverBase; Using previous implementation of the Barton Bandis law, with Kni
…ling the new solver anymore;
LilianeRA
requested review from
OmarDuran,
jhuang2601,
paveltomin and
rrsettgast
LilianeRA
requested review from
CusiniM,
Guotong-Ren,
castelletto1,
cssherman,
dkachuma,
herve-gross,
matteofrigo5,
rasimHZ and
tjb-ltk
as code owners
paveltomin
removed request for
CusiniM,
Guotong-Ren,
matteofrigo5,
paveltomin and
rasimHZ
…ng files, deleting commented code lines.
…Updating the RST documentation.
… the RST documentation; Removing flag for updating stencils; Minor documentation update.
…he new fracture aperture is calculated internally, and it is not propagated to the aperture field. For now, the test requires that the pressure difference to be very small.
…. Replacing it by a constitutive relation for permeability. Updated aperture computed internally. Results still validated by analytical solution. Sample file updated.
jafranc
reviewed
Apr 20, 2026
dkachuma
reviewed
May 22, 2026
dkachuma
left a comment
dkachuma
left a comment
Contributor
There was a problem hiding this comment.
Can you please remove any debug/dead code and sync to develop. Things have moved quite a bit making this a little harder to review.
Removing unused optional flags for input file. Remnants of when the proposed method was modeled as a contact constituive class. Co-authored-by: Dickson Kachuma <81433670+dkachuma@users.noreply.github.com>
…ability.hpp Better variable name description Co-authored-by: Dickson Kachuma <81433670+dkachuma@users.noreply.github.com>
…meability.hpp Suggestion by Kachuma: "I would still use the quadrature index although it's always 0. Just for posterity." Co-authored-by: Dickson Kachuma <81433670+dkachuma@users.noreply.github.com>
…ult. A problem sample is defined in 'stressPathDrivenGeomechanics/'. The pressure and aperture data will be saved in the files 'fracPressure_history.hdf5' and 'fracAperture_history.hdf5'.
…ePassThru function for our new constitutive law; Deleting commented function in FlowSolverBase; Using previous implementation of the Barton Bandis law, with Kni
…ling the new solver anymore;
…he new fracture aperture is calculated internally, and it is not propagated to the aperture field. For now, the test requires that the pressure difference to be very small.
…. Replacing it by a constitutive relation for permeability. Updated aperture computed internally. Results still validated by analytical solution. Sample file updated.
…lts change slightly in the first few iterations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first step for implementing a simplified hydromechanical coupling based on the Barton–Bandis aperture model and a prescribed stress path.
The main change introduced here is the new permeability constitutive law (BartonBandisPermeability) that internally computes fracture aperture, according to the current pressure and normal stress, before updating its permeability.
EDIT: as advised, we are reformulating the code design to better encapsulate what is new: the prescribed stress path implementation. Please, don't review the current code until further notice.