fix: namespace user commitment names with a custom: prefix#2285
Open
Flix6x wants to merge 3 commits into
Open
Conversation
A user commitment named e.g. 'electricity net energy' would shadow the scheduler's internal commitment of the same name in the name-keyed commitment-costs dict of the scheduling results. Prefix user names in convert_to_commitments (idempotently), so users can pick any name. Prepares the commitments editor (#1572), where users type free-form names. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016MLCUiSdXDqDBmg8GbYp1B
Documentation build overview
50 files changed ·
|
1 task
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pxkeq64jtENY7fiWjwUsVS
…mmitment-names Resolve conflicts: - changelog.rst: keep both the #2285 namespacing entry and main's bugfix list. - test_commitments.py: keep both branches' appended tests; drop a duplicate 'ur' import introduced by the merge; adapt main's commodity-matching test to expect the new 'custom:' prefix on user-given commitment names (#2285 x main interaction). Signed-off-by: F.N. Claessen <claessen@seita.nl> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016MLCUiSdXDqDBmg8GbYp1B Signed-off-by: F.N. Claessen <claessen@seita.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the internal namespacing proposed in #1572: a user commitment named e.g.
electricity net energywould shadow the scheduler's internal commitment of the same name in the name-keyed commitment-costs dict of the scheduling results.StorageScheduler.convert_to_commitmentsnow (idempotently) prefixes user-given names withcustom:, so users can pick any name. The prefixed name is what shows up in the commitment costs.documentation/changelog.rstHow to test
Related Items
Prepares the commitments flex-context editor (#1572).
🤖 Generated with Claude Code
https://claude.ai/code/session_016MLCUiSdXDqDBmg8GbYp1B