Skip to content

Fix checker crashes silently passing validation as valid #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RPRKLR wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix checker crashes silently passing validation as valid #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions flexbe_webui/app/_helper/checking.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ const Checking = new (function() {
} catch (error) {
console.log(`\x1b[91m Failed behavior check for '${Behavior.getBehaviorName()}\x1b[0m'\n ${error}`);
console.log(error.stack);
report.fatal_errors.push(error.error);
// error may be a custom {path, error} object or a real JS exception; always record a non-empty message
report.fatal_errors.push(error.error != undefined ? error.error : (error.message != undefined ? error.message : `${error}`));
return report;
}

Expand All @@ -196,16 +197,21 @@ const Checking = new (function() {
} catch (error) {
console.log(`\x1b[91m Failed behavior createStructureInfo for '${Behavior.getBehaviorName()}\x1b[0m'\n ${error}`);
console.log(error.stack);
let container_path = error.path.replace("/"+error.path.split("/").pop(), "");
let container = Behavior.getStatemachine().getStateByPath(container_path);
if (container instanceof BehaviorState) {
error.error += "<br />Note: Since this error is inside a contained behavior, please open this behavior directly and fix it there.";
error.error += "<br />Affected behavior: " + container.getBehaviorName();
container = container.getBehaviorStatemachine();
}
UI.Statemachine.setDisplayedSM(container);
// error may be a custom {path, error} object or a real JS exception; resolve a non-empty message and only
// navigate to the offending container when a path is actually present (a real exception has none).
let error_message = error.error != undefined ? error.error : (error.message != undefined ? error.message : `${error}`);
if (error.path != undefined) {
let container_path = error.path.replace("/"+error.path.split("/").pop(), "");
let container = Behavior.getStatemachine().getStateByPath(container_path);
if (container instanceof BehaviorState) {
error_message += "<br />Note: Since this error is inside a contained behavior, please open this behavior directly and fix it there.";
error_message += "<br />Affected behavior: " + container.getBehaviorName();
container = container.getBehaviorStatemachine();
}
UI.Statemachine.setDisplayedSM(container);
}
UI.Menu.toStatemachineClicked();
report.fatal_errors.push(error.error);
report.fatal_errors.push(error_message);
return report;
}

Expand Down
Loading